[log] Add debug logging to jq middleware filter functions#6715
Merged
Conversation
Add logMiddleware.Printf calls to CompileToolResponseFilter, tryApplyToolResponseFilter, and rewriteFilteredTextPayload in internal/middleware/jqschema.go. These functions previously had no debug instrumentation despite being key entry points in the tool response filter pipeline. The new logs help trace: - When a filter expression is compiled and its length (compile entry/exit) - Whether a response filter is active per tool call (filter present/absent) - Text payload rewrite size when filtered content is applied Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds debug instrumentation to jq tool response filtering paths in internal/middleware/jqschema.go, improving traceability under DEBUG=middleware:* without changing filter behavior.
Changes:
- Logs jq filter expression length before compilation and success after compilation.
- Logs per-call filter presence with tool/query identifiers.
- Logs filtered text length when rewriting the primary text payload.
Show a summary per file
| File | Description |
|---|---|
internal/middleware/jqschema.go |
Adds debug logging to tool response filter compilation, application, and text payload rewrite helpers. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
logMiddleware.Printfcalls to three functions ininternal/middleware/jqschema.gothat previously had no debug instrumentation:Changes
CompileToolResponseFilter: logs filter expression length on entry, and confirms successful compilation on exit — useful for diagnosing filter parse/compile failurestryApplyToolResponseFilter: logs the tool name, query ID, and whether a filter is active — helps distinguish between filtered and unfiltered tool call pathsrewriteFilteredTextPayload: logs the length of the filtered text being written back — provides visibility into the rewrite step when a tool response filter is appliedWhy these functions?
These are key entry points in the tool response filter pipeline. The surrounding code (
wrapToolHandler,savePayload,applyJqSchema) already has thorough logging, but these intermediate helpers were opaque when tracing filter-related issues underDEBUG=middleware:*.Validation
make format build lint test-unit test-integration— all pass ✓Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
index.crates.ioSee Network Configuration for more information.